Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround VM first start failure due to swtpm #5946

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

workaround VM first start failure due to swtpm #5946

wants to merge 1 commit into from

Conversation

chunfuwen
Copy link
Contributor

@chunfuwen chunfuwen commented Oct 22, 2024 •
edited
Loading

On rhel 10, swtpm will fail VM first start due to existed known issue, so here it is just to start vm again once first start failure

@chunfuwen
Copy link
Contributor Author

tpm_device.normal_test.tpm-crb_model.emulator.encrypted.pcrbank_all.restart_libvirtd 49 sec Fixed
tpm_device.normal_test.tpm-crb_model.emulator.encrypted.pcrbank_all.restart_vm.remove_pcrbank 1 min 12 sec Fixed
tpm_device.normal_test.tpm-crb_model.emulator.encrypted.pcrbank_all.restore_vm 1 min 4 sec Fixed
tpm_device.normal_test.tpm-crb_model.emulator.encrypted.pcrbank_all.snapshot_operate 56 sec Fixed
tpm_device.normal_test.tpm-crb_model.emulator.encrypted.pcrbank_all.suspend_resume 52 sec Fixed
tpm_device.normal_test.tpm-crb_model.emulator.encrypted.pcrbank_all.undefine_create 1 min 19 sec Fixed
tpm_device.normal_test.tpm-crb_model.emulator.encrypted.pcrbank_default.basic 45 sec Fixed

@chunfuwen
Copy link
Contributor Author

@yanqzhan since existed swtpm issue fail lots of cases, we may need this workaround solution.
Once issue is really resolved, we can remove these code accordingly.

@yanqzhan
Copy link
Contributor

Looks good, thank for this. but
vm2 also needs it:
L708 ret = virsh.start(vm2_name, ignore_status=True, debug=True)

IMO, suggest to add "CI_PR": "tp-libvirt xxxx" in ci jobs.yaml instead of merge here and remove later.

@chunfuwen
workaround VM first start failure due to swtpm
a75a21a 
Signed-off-by: chunfuwen <chwen@redhat.com>
@chunfuwen chunfuwen force-pushed the workaround_vm_first_start_failure_swtpm branch from 1a84f58 to a75a21a Compare October 24, 2024 08:26
@yanqzhan
Copy link
Contributor

LGTM now.

@chunfuwen chunfuwen marked this pull request as draft October 24, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chunfuwen @yanqzhan